From 6a6afcc232ea4a70d385d902a6a18c2379a24e28 Mon Sep 17 00:00:00 2001 From: simonkellet Date: Sat, 3 Sep 2022 13:46:41 +0100 Subject: [PATCH] changes for error msg --- file.go | 1 + json.go | 1 + main.go | 3 ++- web.go | 3 ++- 4 files changed, 6 insertions(+), 2 deletions(-) diff --git a/file.go b/file.go index 8b22282..3f43a0f 100644 --- a/file.go +++ b/file.go @@ -23,4 +23,5 @@ func removeFile(file string) { if e != nil { log.Fatal(e) } + } diff --git a/json.go b/json.go index cf6fac5..fb907b1 100644 --- a/json.go +++ b/json.go @@ -16,4 +16,5 @@ func loadJSON(file string) (WeatherAPI, error) { jsonParser := json.NewDecoder(configFile) jsonParser.Decode(&config) return config, err + } diff --git a/main.go b/main.go index fef1293..d98a7cb 100644 --- a/main.go +++ b/main.go @@ -19,7 +19,8 @@ func main() { //read webpage html, err := loadWebPage(full) if err != nil { - fmt.Println("4xx error, please try again!") + //fmt.Println("4xx error, please try again!") + fmt.Fprintf(os.Stderr, "ERROR: Could not read website: %s\n", err) os.Exit(1) } diff --git a/web.go b/web.go index c51e648..34a51db 100644 --- a/web.go +++ b/web.go @@ -10,10 +10,11 @@ func loadWebPage(webURL string) ([]byte, error) { resp, err := http.Get(webURL) //reads html as a slice of bytes html, err := ioutil.ReadAll(resp.Body) + defer resp.Body.Close() //check response codes if resp.StatusCode >= 400 && resp.StatusCode <= 499 { - err = fmt.Errorf("response Code: %v", resp.StatusCode) + err = fmt.Errorf("got response code %v", resp.StatusCode) } return html, err